Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay close tab on middle-click till pointer released #9842

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Delay close tab on middle-click till pointer released #9842

merged 1 commit into from
Apr 15, 2021

Conversation

Don-Vito
Copy link
Contributor

PR Checklist

Not sure what is the reason for handling right button.
But delaying it to PointerReleased seems not to regress anything.

@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 15, 2021
miniksa
miniksa approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

PankajBhojwani
PankajBhojwani approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@PankajBhojwani PankajBhojwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you!

@miniksa miniksa added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. AutoMerge Marked for automatic merge by the bot when requirements are met labels Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 35 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Apr 15, 2021

@msftbot merge this in 5

@ghost
Copy link

ghost commented Apr 15, 2021

Hello @DHowett!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@DHowett
Copy link
Member

DHowett commented Apr 15, 2021

@msftbot merge this in minutes

@ghost
Copy link

ghost commented Apr 15, 2021

Hello @DHowett!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@DHowett DHowett merged commit 05e7ea1 into microsoft:main Apr 15, 2021
@miniksa
Copy link
Member

miniksa commented Apr 15, 2021

LOL @DHowett

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Apr 17, 2021
@Don-Vito @mpela81
Delay close tab on middle-click till pointer released (microsoft#9842)
e1b6440 
## PR Checklist
* [x] Closes microsoft#9836
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. 

Not sure what is the reason for handling right button. 
But delaying it to PointerReleased seems not to regress anything.
@DHowett DHowett removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label May 14, 2021
DHowett pushed a commit that referenced this pull request May 14, 2021
@Don-Vito @DHowett
Delay close tab on middle-click till pointer released (#9842)
9e93ccb 
* [x] Closes #9836
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

Not sure what is the reason for handling right button.
But delaying it to PointerReleased seems not to regress anything.

(cherry picked from commit 05e7ea1)
DHowett pushed a commit that referenced this pull request May 14, 2021
@Don-Vito @DHowett
Delay close tab on middle-click till pointer released (#9842)
ac864d2 
## PR Checklist
* [x] Closes #9836
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

Not sure what is the reason for handling right button.
But delaying it to PointerReleased seems not to regress anything.

(cherry picked from commit 05e7ea1)
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal v1.8.1444.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 25, 2021
Closed
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Don-Vito @DHowett @miniksa @PankajBhojwani